ProPeace/de.forumzfd.twinglecampaign
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

👾 bug fix: cid changes when updating TwingleCampaing

Browse source
This commit is contained in:
Marc Michalsky 2021-10-04 09:37:19 +02:00
parent 06e30f6ef7
commit 108d2c9586
1 changed files with 9 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

27
CRM/TwingleCampaign/BAO/TwingleCampaign.php
View file

@ -17,32 +17,31 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
private $values; private $values;
/** /**
* ## TwingleCampaign constructor * ## TwingleCampaign constructor
* *
* @param array|null $values * @param array $values
* @param int|null $id
* *
* @throws \CiviCRM_API3_Exception * @throws \CiviCRM_API3_Exception
*/ */
public function __construct(array $values = [], int $id = NULL) { public function __construct(array $values = []) {
$this->prefix = 'twingle_campaign_'; $this->prefix = 'twingle_campaign_';
$this->id = $id ?? NULL; $this->id = $values['id'] ?? NULL;
$this->values['campaign_type_id'] = 'twingle_campaign'; $this->values['campaign_type_id'] = 'twingle_campaign';
if ($this->id != NULL) {
$this->fetch($this->id);
}
$this->update($values); $this->update($values);
$this->getParentProject(); $this->getParentProject();
if (!isset($this->values['cid'])) { if (!isset($this->values['cid'])) {
$this->createCid(); $this->createCid();
} }
$this->createUrl(); $this->createUrl();
} }
/** /**
* ## Create TwingleCampaign * ## Create TwingleCampaign
* Create this TwingleCampaign as a campaign in CiviCRM * Create this TwingleCampaign as a campaign in CiviCRM
@ -69,19 +68,17 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
} }
} }
/** /**
* ## Fetch TwingleCampaign * ## Fetch TwingleCampaign
* Populate this instance with values from an existing TwingleCampaign. * Populate this instance with values from an existing TwingleCampaign.
* *
* @throws CiviCRM_API3_Exception * @throws CiviCRM_API3_Exception
*/ */
public function fetch() { public function fetch(int $id) {
$this->values = civicrm_api3('TwingleCampaign', 'getsingle', $this->values = civicrm_api3('TwingleCampaign', 'getsingle',
['id' => $this->id]); ['id' => $id]);
} }
/** /**
* ## Get Parent Project * ## Get Parent Project
* Determines the id of the parent TwingleProject. If there is no parent * Determines the id of the parent TwingleProject. If there is no parent
@ -128,7 +125,6 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
} }
} }
// Set parent_project_id and retrieve parent_project_url // Set parent_project_id and retrieve parent_project_url
if ($parent_campaign_type_id == $twingle_project_campaign_type_id) { if ($parent_campaign_type_id == $twingle_project_campaign_type_id) {
$this->values['parent_project_id'] = $parent_id; $this->values['parent_project_id'] = $parent_id;
@ -205,7 +201,6 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
$this->values['parent_project_url'] . '?tw_cid=' . $this->values['cid']; $this->values['parent_project_url'] . '?tw_cid=' . $this->values['cid'];
} }
/** /**
* *
*/ */
@ -214,7 +209,6 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
$this->values['cid'] = uniqid(); $this->values['cid'] = uniqid();
} }
/** /**
* ## Translate field names and custom field names * ## Translate field names and custom field names
* *
@ -283,7 +277,6 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
} }
} }
/** /**
* ## Delete TwingleCampaign * ## Delete TwingleCampaign
* Deletes this TwingleCampaign from CiviCRM * Deletes this TwingleCampaign from CiviCRM
@ -303,7 +296,6 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
} }
} }
/** /**
* ## Get a response * ## Get a response
* Get a response that describes the status of this TwingleCampaign instance. * Get a response that describes the status of this TwingleCampaign instance.
@ -380,5 +372,4 @@ class CRM_TwingleCampaign_BAO_TwingleCampaign {
return (int) $this->id; return (int) $this->id;
} }
} }