From 34bf53b51bb1dbad365473f18bfe69d3bcb77f84 Mon Sep 17 00:00:00 2001
From: Marc Michalsky forumZFD <michalsky@forumzfd.de>
Date: Wed, 10 Feb 2021 18:08:48 +0100
Subject: [PATCH] code cleanup

---
 api/v3/TwingleCampaign/Create.php | 4 ++--
 api/v3/TwingleForm/Create.php     | 7 ++++++-
 api/v3/TwingleProject/Create.php  | 3 ++-
 twinglecampaign.php               | 2 --
 4 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/api/v3/TwingleCampaign/Create.php b/api/v3/TwingleCampaign/Create.php
index e5c4f15..dbb1df6 100644
--- a/api/v3/TwingleCampaign/Create.php
+++ b/api/v3/TwingleCampaign/Create.php
@@ -14,10 +14,10 @@ use CRM_TwingleCampaign_ExtensionUtil as E;
 function _civicrm_api3_twingle_campaign_Create_spec(array &$spec) {
   $spec['id'] = [
     'name'         => 'id',
-    'title'        => E::ts('Twingle Project ID'),
+    'title'        => E::ts('Twingle Campaign ID'),
     'type'         => CRM_Utils_Type::T_INT,
     'api.required' => 0,
-    'description'  => E::ts('The Twingle Project ID'),
+    'description'  => E::ts('The Twingle Campaign ID'),
   ];
   $spec['name'] = [
     'name'         => 'name',
diff --git a/api/v3/TwingleForm/Create.php b/api/v3/TwingleForm/Create.php
index 131b44e..6244df1 100644
--- a/api/v3/TwingleForm/Create.php
+++ b/api/v3/TwingleForm/Create.php
@@ -49,7 +49,12 @@ function civicrm_api3_twingle_form_Create(array $params): array {
   $result = civicrm_api3('TwingleProject', 'create', $params);
 
   if ($result['is_error'] != 1) {
-    return civicrm_api3_create_success($result,$params,'TwingleForm', 'create',);
+    return civicrm_api3_create_success(
+      $result['values'],
+      $params,
+      'TwingleForm',
+      'create',
+    );
   }
   else {
     return civicrm_api3_create_error(
diff --git a/api/v3/TwingleProject/Create.php b/api/v3/TwingleProject/Create.php
index 0944984..21b1280 100644
--- a/api/v3/TwingleProject/Create.php
+++ b/api/v3/TwingleProject/Create.php
@@ -59,7 +59,7 @@ function _civicrm_api3_twingle_project_Create_spec(array &$spec) {
 }
 
 /**
- * TwingleProject.Create API
+ * # TwingleProject.Create API
  *
  * @param array $params
  *
@@ -85,6 +85,7 @@ function civicrm_api3_twingle_project_Create(array $params): array {
       $result['values']['id'] = $result['values']['project_id'];
       unset($result['values']['project_id']);
       $project = new TwingleProject($result['values'], $params['id']);
+      unset($params['id']);
       $project->update($params);
       $project->setEmbedData($params);
     }
diff --git a/twinglecampaign.php b/twinglecampaign.php
index 7f39095..fe0b7bb 100644
--- a/twinglecampaign.php
+++ b/twinglecampaign.php
@@ -1,8 +1,6 @@
 <?php
 
 use CRM_TwingleCampaign_Utils_ExtensionCache as ExtensionCache;
-use CRM_TwingleCampaign_BAO_TwingleCampaign as TwingleCampaign;
-use CRM_TwingleCampaign_BAO_TwingleProject as TwingleProject ;
 use CRM_TwingleCampaign_ExtensionUtil as E;
 
 require_once 'twinglecampaign.civix.php';