ProPeace/de.forumzfd.twinglecampaign
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

code cleanup

Browse source
This commit is contained in:
Marc Michalsky forumZFD 2021-02-22 18:25:35 +01:00
parent 520fdb9f8d
commit 537ed5cb02
Signed by untrusted user who does not match committer: marc.koch
GPG key ID: 12406554CFB028B9
3 changed files with 55 additions and 196 deletions
Download patch file Download diff file Expand all files Collapse all files

34
CRM/TwingleCampaign/BAO/CustomGroup.php
View file

@ -3,23 +3,38 @@
class CRM_TwingleCampaign_BAO_CustomGroup {
private $id;
private $title;
private $name;
private $extends;
private $weight;
private $extends_entity_column_value;
private $collapse_display;
private $results;
private $extensionName;
/**
* CustomGroup constructor.
*
* @param array $attributes
*/
public function __construct(array $attributes) {
$this->extensionName = E::LONG_NAME;
foreach ($this as $var => $value) {
if (array_key_exists($var, $attributes))
// put array items into attributes
if (array_key_exists($var, $attributes)) {
$this->$var = $attributes[$var];
}
}
}
@ -33,7 +48,7 @@ class CRM_TwingleCampaign_BAO_CustomGroup {
'get',
[
'sequential' => 1,
'name' => $this->getName()
'name' => $this->getName(),
]
);
@ -44,7 +59,7 @@ class CRM_TwingleCampaign_BAO_CustomGroup {
$this->id = $this->results['id'];
if ($this->results['is_error'] == 0) {
Civi::log()->info("TwingleCampaign Extension has created a new custom group.
Civi::log()->info("$this->extensionName has created a new custom group.
title: $this->title
name: $this->name
extends: $this->extends
@ -54,12 +69,12 @@ class CRM_TwingleCampaign_BAO_CustomGroup {
}
else {
if ($this->title) {
Civi::log()->error("TwingleCampaign Extension could not create new custom group
Civi::log()->error("$this->extensionName could not create new custom group
for \"$this->title\": $this->results['error_message']"
);
}
else {
Civi::log()->error("TwingleCampaign Extension could not create new
Civi::log()->error("$this->extensionName could not create new
custom group: $this->results['error_message']");
}
}
@ -111,7 +126,7 @@ class CRM_TwingleCampaign_BAO_CustomGroup {
'get',
[
'sequential' => 1,
'name' => $name
'name' => $name,
]
);
if ($custom_group = array_shift($custom_group['values'])) {
@ -121,6 +136,7 @@ class CRM_TwingleCampaign_BAO_CustomGroup {
return NULL;
}
}
public function delete() {
$this->results = civicrm_api3(
'CustomGroup',
@ -129,7 +145,7 @@ class CRM_TwingleCampaign_BAO_CustomGroup {
);
if ($this->results['is_error'] == 0) {
Civi::log()->info("TwingleCampaign Extension has deleted custom group.
Civi::log()->info("$this->extensionName has deleted custom group.
title: $this->title
name: $this->name
extends: $this->extends
@ -142,12 +158,12 @@ class CRM_TwingleCampaign_BAO_CustomGroup {
}
else {
if ($this->title) {
Civi::log()->error("TwingleCampaign Extension could not delete custom group
Civi::log()->error("$this->extensionName could not delete custom group
\"$this->title\": $this->results['error_message']"
);
}
else {
Civi::log()->error("TwingleCampaign Extension could not delete custom group:
Civi::log()->error("$this->extensionName could not delete custom group:
$this->results['error_message']");
}
}