From 5a09523af7a15cfa9354ad27616951a95a18d30d Mon Sep 17 00:00:00 2001
From: Marc Michalsky forumZFD <michalsky@forumzfd.de>
Date: Thu, 10 Dec 2020 15:18:26 +0100
Subject: [PATCH] use less variables

---
 api/v3/TwingleForm/Get.php | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/api/v3/TwingleForm/Get.php b/api/v3/TwingleForm/Get.php
index d927fd0..cfc2b5b 100644
--- a/api/v3/TwingleForm/Get.php
+++ b/api/v3/TwingleForm/Get.php
@@ -58,14 +58,11 @@ function civicrm_api3_twingle_form_Get(array $params) {
 
   // Get custom fields
   $custom_field_mapping = Cache::getInstance()->getCustomFieldMapping();
-  $cf_twingle_project_id = $custom_field_mapping['twingle_project_id'];
-  $cf_twingle_project_type = $custom_field_mapping['twingle_project_type'];
-  $cf_twingle_project_widget = $custom_field_mapping['twingle_project_widget'];
-  $cf_twingle_project_counter = $custom_field_mapping['twingle_project_counter'];
 
   // Replace twingle_project_type key with custom field name
   if (key_exists('twingle_project_type', $params)) {
-    $params[$cf_twingle_project_type] = $params['twingle_project_type'];
+    $params[$custom_field_mapping['twingle_project_type']] =
+      $params['twingle_project_type'];
     unset($params['twingle_project_type']);
   }
 
@@ -87,12 +84,12 @@ function civicrm_api3_twingle_form_Get(array $params) {
           $returnValues,
           [
             'id' => $value['id'],
-            'twingle_project_id' => $value[$cf_twingle_project_id],
+            'twingle_project_id' => $value[$custom_field_mapping['twingle_project_id']],
             'title' => $value['title'],
             'name' => $value['name'],
-            'project_type' => $value[$cf_twingle_project_type],
-            'embed_code' => $value[$cf_twingle_project_widget],
-            'counter' => $value[$cf_twingle_project_counter]
+            'project_type' => $value[$custom_field_mapping['twingle_project_type']],
+            'embed_code' => $value[$custom_field_mapping['twingle_project_widget']],
+            'counter' => $value[$custom_field_mapping['twingle_project_counter']]
           ]
         );
       }