ProPeace/de.forumzfd.twinglecampaign
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

outsource name splitting to StringOperations class

Browse source
This commit is contained in:
Marc Michalsky forumZFD 2020-12-14 17:29:53 +01:00
parent 59c9581bfb
commit 65c5981eb8
Signed by untrusted user who does not match committer: marc.koch
GPG key ID: 12406554CFB028B9
1 changed files with 5 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

31
CRM/TwingleCampaign/BAO/TwingleEvent.php
View file

@ -330,34 +330,13 @@ class CRM_TwingleCampaign_BAO_TwingleEvent extends Campaign {
* Returns a contact id * Returns a contact id
*/ */
private function matchContact(string $names, string $email) { private function matchContact(string $names, string $email) {
$names = explode(' ', $names); $names = StringOps::split_names($names); // Hopefully just a temporary solution
$lastname = ''; $firstnames = $names['firstnames'];
$lastname = $names['lastname'];
if (is_array($names) && count($names) > 1) {
$lastname = array_pop($names);
$test = $names[count($names) - 1];
$lastnamePrefixes = ['da', 'de', 'der', 'van', 'von'];
if (in_array($test, $lastnamePrefixes)) {
if ($test == 'der' &&
$names[count($names) - 2] == 'van' ||
$names[count($names) - 2] == 'von'
) {
$lastname = implode(' ', array_splice($names, -2))
. ' ' . $lastname;
}
else {
array_pop($names);
$lastname = $test . ' ' . $lastname;
}
}
$names = implode(" ", $names);
}
try { try {
$contact = civicrm_api3('Contact', 'getorcreate', [ $contact = civicrm_api3('Contact', 'getorcreate', [
'xcm_profile' => Civi::settings()->get('twinglecampaign_xcm_profile'), 'xcm_profile' => Civi::settings()->get('twinglecampaign_xcm_profile'),
'first_name' => $names, 'first_name' => $firstnames,
'last_name' => $lastname, 'last_name' => $lastname,
'email' => $email, 'email' => $email,
]); ]);
@ -365,7 +344,7 @@ class CRM_TwingleCampaign_BAO_TwingleEvent extends Campaign {
} catch (CiviCRM_API3_Exception $e) { } catch (CiviCRM_API3_Exception $e) {
$errorMessage = $e->getMessage(); $errorMessage = $e->getMessage();
Civi::log()->error("TwingleCampaign extension could not match or create a contact for: Civi::log()->error("TwingleCampaign extension could not match or create a contact for:
$names $lastname $email./nError Message: $errorMessage"); $firstnames $lastname $email./nError Message: $errorMessage");
return NULL; return NULL;
} }
} }