ProPeace/de.forumzfd.twinglecampaign
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clean up

Browse source 
improve method documentation and more
This commit is contained in:
Marc Michalsky forumZFD 2021-02-01 14:33:03 +01:00
parent 9df3ff4153
commit 88474c10ac
Signed by untrusted user who does not match committer: marc.koch
GPG key ID: 12406554CFB028B9
10 changed files with 305 additions and 381 deletions
Download patch file Download diff file Expand all files Collapse all files

31
api/v3/TwingleProject/Create.php
View file

@ -86,14 +86,33 @@ function _civicrm_api3_twingle_project_Create_spec(array &$spec) {
* @see civicrm_api3_create_success
*
*/
function civicrm_api3_twingle_project_Create($params) {
$returnValues = [];
function civicrm_api3_twingle_project_Create($params): array {
// For logging purpose
$extensionName = E::LONG_NAME;
// instantiate project
$project = new TwingleProject($params, 'TWINGLE');
if (!$project->exists()) {
$returnValues = $project->create();
}
// Try to create the TwingleProject campaign
try {
$project->create();
return civicrm_api3_create_success(
$project->getResponse('TwingleProject created'),
$params,
'TwingleProject',
'Create'
);
} catch(Exception $e){
$errorMessage = $e->getMessage();
Civi::log()->error(
"$extensionName could not create TwingleProject: $errorMessage",
$project->getResponse()
);
return civicrm_api3_create_error(
"Could not create TwingleProject: $errorMessage",
$project->getResponse()
);
}
return civicrm_api3_create_success($returnValues, $params, 'TwingleProject', 'Create');
}

5
api/v3/TwingleProject/Get.php
View file

@ -152,8 +152,9 @@ function civicrm_api3_twingle_project_Get(array $params): array {
}
}
try {
TwingleProject::translateKeys($returnValues[$project['id']], TwingleProject::OUT);
TwingleProject::formatValues($returnValues[$project['id']], TwingleProject::OUT);
$tmp_project = new TwingleProject([]);
$tmp_project->translateKeys($returnValues[$project['id']], TwingleProject::OUT);
$tmp_project->formatValues($returnValues[$project['id']], TwingleProject::OUT);
}
catch (Exception $e) {
throw new API_Exception($e->getMessage());