From 0cf7ccb1cba251667616a3c52e09c07f7688fbd6 Mon Sep 17 00:00:00 2001
From: Jens Schuppe <schuppe@systopia.de>
Date: Wed, 12 Jun 2024 15:18:35 +0200
Subject: [PATCH] Code style

---
 CRM/Twingle/Form/Profile.php      |  3 ++-
 CRM/Twingle/Tools.php             |  5 ++++-
 api/v3/TwingleDonation/Submit.php | 12 ++++--------
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/CRM/Twingle/Form/Profile.php b/CRM/Twingle/Form/Profile.php
index 2159d3b..086dc2b 100644
--- a/CRM/Twingle/Form/Profile.php
+++ b/CRM/Twingle/Form/Profile.php
@@ -607,7 +607,8 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
         if (!isset($profile_data[$key]) && $required) {
           CRM_Core_Session::setStatus(
             E::ts(
-              'The required configuration option "%1" has no value. Saving the profile might set this option to a possibly unwanted default value.',
+              'The required configuration option "%1" has no value.'
+              . ' Saving the profile might set this option to a possibly unwanted default value.',
               [1 => $metadata['label'] ?? $key]
             ),
             E::ts('Error'),
diff --git a/CRM/Twingle/Tools.php b/CRM/Twingle/Tools.php
index 9725a96..e2abc92 100644
--- a/CRM/Twingle/Tools.php
+++ b/CRM/Twingle/Tools.php
@@ -116,7 +116,10 @@ class CRM_Twingle_Tools {
    *   Recurring contribution fields.
    * @throws Exception could be one of the measures
    */
-  public static function processRecurringContributionTermination(int $recurring_contribution_id, array $recurring_contribution) {
+  public static function processRecurringContributionTermination(
+    int $recurring_contribution_id,
+    array $recurring_contribution
+  ) {
     // check if we're suspended
     if (self::$protection_suspended) {
       return;
diff --git a/api/v3/TwingleDonation/Submit.php b/api/v3/TwingleDonation/Submit.php
index 687f245..daceb36 100644
--- a/api/v3/TwingleDonation/Submit.php
+++ b/api/v3/TwingleDonation/Submit.php
@@ -532,8 +532,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
       : 'false';
     if (
       (bool) $profile->getAttribute('newsletter_double_opt_in')
-      && isset($params['newsletter'])
-      && 1 == $params['newsletter']
+      && (bool) ($params['newsletter'] ?? FALSE)
       && is_array($groups = $profile->getAttribute('newsletter_groups'))
     ) {
       $group_memberships = array_column(
@@ -573,8 +572,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
       // If requested, add contact to newsletter groups defined in the profile.
     }
     elseif (
-      isset($params['newsletter'])
-      && 1 == $params['newsletter']
+      (bool) ($params['newsletter'] ?? FALSE)
       && is_array($groups = $profile->getAttribute('newsletter_groups'))
     ) {
       foreach ($groups as $group_id) {
@@ -593,8 +591,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
 
     // If requested, add contact to postinfo groups defined in the profile.
     if (
-      isset($params['postinfo'])
-      && 1 == $params['postinfo']
+      (bool) ($params['postinfo'] ?? FALSE)
       && is_array($groups = $profile->getAttribute('postinfo_groups'))
     ) {
       foreach ($groups as $group_id) {
@@ -611,8 +608,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
     // profile. If an organisation is provided, add it to the groups instead.
     // (see issue #83)
     if (
-      isset($params['donation_receipt'])
-      && 1 == $params['donation_receipt']
+      (bool) ($params['donation_receipt'] ?? FALSE)
       && is_array($groups = $profile->getAttribute('donation_receipt_groups'))
     ) {
       foreach ($groups as $group_id) {