ProPeace/de.systopia.twingle
6
0
Fork 0
Code Issues 2 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Fix ambiguous conditions replacing empty()

Browse source
This commit is contained in:
Jens Schuppe 2024-05-10 12:27:33 +02:00
parent 48c49c1814
commit 2b8ab813db
3 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
api/v3/TwingleDonation/Submit.php
View file

@ -420,7 +420,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
// Get the prefix ID defined within the profile
if (
isset($params['user_gender'])
&& NULL !== ($prefix_id = $profile->getAttribute('prefix_' . $params['user_gender']))
&& is_numeric($prefix_id = $profile->getAttribute('prefix_' . $params['user_gender']))
) {
$contact_data['prefix_id'] = $prefix_id;
}
@ -830,8 +830,8 @@ function civicrm_api3_twingle_donation_Submit($params) {
$result_values['membership'] = $membership;
// call the postprocess API
$postprocess_call = $profile->getAttribute('membership_postprocess_call');
if (is_string($postprocess_call)) {
if ('' !== ($postprocess_call = $profile->getAttribute('membership_postprocess_call', ''))) {
/** @var string $postprocess_call */
[$pp_entity, $pp_action] = explode('.', $postprocess_call, 2);
try {
// gather the contribution IDs