From 4ec0fef825516738d22c65207a417525b0cf2345 Mon Sep 17 00:00:00 2001
From: "B. Endres" <endres@systopia.de>
Date: Fri, 19 Jun 2020 15:13:31 +0200
Subject: [PATCH 1/2] [#31] only create memberships on initial payments

---
 api/v3/TwingleDonation/Submit.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/api/v3/TwingleDonation/Submit.php b/api/v3/TwingleDonation/Submit.php
index f84d21c..f434d63 100644
--- a/api/v3/TwingleDonation/Submit.php
+++ b/api/v3/TwingleDonation/Submit.php
@@ -704,7 +704,10 @@ function civicrm_api3_twingle_donation_Submit($params) {
       $membership_type_id = $profile->getAttribute('membership_type_id_recur');
     }
     else {
-      $membership_type_id = $profile->getAttribute('membership_type_id');
+      // only create memberships, if this isn't an installment
+      if (empty($params['parent_trx_id'])) {
+        $membership_type_id = $profile->getAttribute('membership_type_id');
+      }
     }
     if (!empty($membership_type_id)) {
       // create the membership

From da790863b574ec346839e95af1df7b1d5541145c Mon Sep 17 00:00:00 2001
From: "B. Endres" <endres@systopia.de>
Date: Fri, 19 Jun 2020 15:25:59 +0200
Subject: [PATCH 2/2] [#31] only create memberships on initial payments

---
 api/v3/TwingleDonation/Submit.php | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/api/v3/TwingleDonation/Submit.php b/api/v3/TwingleDonation/Submit.php
index f434d63..5537683 100644
--- a/api/v3/TwingleDonation/Submit.php
+++ b/api/v3/TwingleDonation/Submit.php
@@ -703,12 +703,11 @@ function civicrm_api3_twingle_donation_Submit($params) {
     if ($params['donation_rhythm'] != 'one_time') {
       $membership_type_id = $profile->getAttribute('membership_type_id_recur');
     }
-    else {
-      // only create memberships, if this isn't an installment
-      if (empty($params['parent_trx_id'])) {
-        $membership_type_id = $profile->getAttribute('membership_type_id');
-      }
+    elseif (empty($params['parent_trx_id'])) {
+      // only create memberships, if this isn't an installment (e.g. parent_trx_id is set)
+      $membership_type_id = $profile->getAttribute('membership_type_id');
     }
+
     if (!empty($membership_type_id)) {
       // create the membership
       $membership_data = [