Fix code style issues.

This commit is contained in:
Jens Schuppe 2018-10-10 10:22:28 +02:00
parent 42c40e8c00
commit 8ff71e277e
5 changed files with 23 additions and 8 deletions

View file

@ -280,6 +280,10 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
/**
* Retrieves location types present within the system as options for select
* form elements.
*
* @return array
*
* @throws \CiviCRM_API3_Exception
*/
public function getLocationTypes() {
$location_types = array();
@ -296,6 +300,10 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
/**
* Retrieves financial types present within the system as options for select
* form elements.
*
* @return array
*
* @throws \CiviCRM_API3_Exception
*/
public function getFinancialTypes() {
$financial_types = array();
@ -313,6 +321,10 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
/**
* Retrieves campaigns present within the system as options for select form
* elements.
*
* @return array
*
* @throws \CiviCRM_API3_Exception
*/
public function getGenderOptions() {
$genders = array();
@ -335,6 +347,7 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
* Retrieves CiviSEPA creditors as options for select form elements.
*
* @return array
*
* @throws \CiviCRM_API3_Exception
*/
public function getSepaCreditors() {

View file

@ -132,6 +132,8 @@ class CRM_Twingle_Form_Settings extends CRM_Core_Form {
* Get the settings we are going to allow to be set on this form.
*
* @return array
*
* @throws \CiviCRM_API3_Exception
*/
function getFormSettings() {
if (empty($this->_settings)) {

View file

@ -90,7 +90,8 @@ class CRM_Twingle_Submission {
// Get the gender ID defined within the profile, or return an error if none
// matches (i.e. an unknown gender was submitted).
if (!empty($params['user_gender']) && !$gender_id = $profile->getAttribute('gender_' . $params['user_gender'])) {
if (!empty($params['user_gender'])) {
if (!$gender_id = $profile->getAttribute('gender_' . $params['user_gender'])) {
throw new CiviCRM_API3_Exception(
E::ts('Gender could not be matched to existing gender.'),
'invalid_format'
@ -98,6 +99,7 @@ class CRM_Twingle_Submission {
}
$params['gender_id'] = $gender_id;
}
}
/**
* Retrieves the contact matching the given contact data or creates a new

View file

@ -63,7 +63,6 @@ function _civicrm_api3_twingle_donation_Cancel_spec(&$params) {
* @return array API result descriptor
* @see civicrm_api3_create_success
* @see civicrm_api3_create_error
* @throws API_Exception
*/
function civicrm_api3_twingle_donation_Cancel($params) {
try {

View file

@ -56,7 +56,6 @@ function _civicrm_api3_twingle_donation_EndRecurring_spec(&$params) {
* @return array API result descriptor
* @see civicrm_api3_create_success
* @see civicrm_api3_create_error
* @throws API_Exception
*/
function civicrm_api3_twingle_donation_EndRecurring($params) {
try {