ProPeace/de.systopia.twingle
6
0
Fork 0
Code Issues 2 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Code style

Browse source
This commit is contained in:
Jens Schuppe 2024-06-13 13:24:34 +02:00
parent ff24256bc1
commit 96d0e5fbec
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
api/v3/TwingleDonation/Submit.php
View file

@ -535,6 +535,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
&& (bool) ($params['newsletter'] ?? FALSE) && (bool) ($params['newsletter'] ?? FALSE)
&& is_array($groups = $profile->getAttribute('newsletter_groups')) && is_array($groups = $profile->getAttribute('newsletter_groups'))
) { ) {
// TODO: Ensure the values being integers.
$group_memberships = array_column( $group_memberships = array_column(
civicrm_api3( civicrm_api3(
'GroupContact', 'GroupContact',
@ -564,7 +565,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
'contact_id' => $contact_id, 'contact_id' => $contact_id,
] ]
); );
$subscription = CRM_Utils_Array::first($result['values']); $subscription = reset($result['values']);
$subscription['group_id'] = $group_id; $subscription['group_id'] = $group_id;
$result_values['newsletter_subscriptions'][] = $subscription; $result_values['newsletter_subscriptions'][] = $subscription;
} }
@ -725,7 +726,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
// Create the mandate. // Create the mandate.
$mandate = civicrm_api3('SepaMandate', 'createfull', $mandate_data); $mandate = civicrm_api3('SepaMandate', 'createfull', $mandate_data);
$result_values['sepa_mandate'] = CRM_Utils_Array::first($mandate['values']); $result_values['sepa_mandate'] = reset($mandate['values']);
} }
else { else {
// Set financial type depending on donation rhythm. This applies for // Set financial type depending on donation rhythm. This applies for
@ -798,12 +799,15 @@ function civicrm_api3_twingle_donation_Submit($params) {
} }
$contribution = civicrm_api3('Contribution', 'create', $contribution_data); $contribution = civicrm_api3('Contribution', 'create', $contribution_data);
if ($contribution['is_error']) { /** @phpstan-var array{'values': array<int, array<mixed>>, 'is_error'?: string} $contribution */
if ((bool) ($contribution['is_error'] ?? FALSE)) {
throw new CRM_Core_Exception( throw new CRM_Core_Exception(
E::ts('Could not create contribution'), E::ts('Could not create contribution'),
'api_error' 'api_error'
); );
} }
$contribution = reset($contribution['values']);
/** @phpstan-var array{'id': int} $contribution */
// Add notes to the contribution. // Add notes to the contribution.
/** @phpstan-var array<string> $contribution_note_mappings */ /** @phpstan-var array<string> $contribution_note_mappings */
@ -816,13 +820,13 @@ function civicrm_api3_twingle_donation_Submit($params) {
) { ) {
Note::create(FALSE) Note::create(FALSE)
->addValue('entity_table', 'civicrm_contribution') ->addValue('entity_table', 'civicrm_contribution')
->addValue('entity_id', reset($contribution['values'])['id']) ->addValue('entity_id', $contribution['id'])
->addValue('note', reset($params[$target])) ->addValue('note', reset($params[$target]))
->execute(); ->execute();
} }
} }
$result_values['contribution'] = CRM_Utils_Array::first($contribution['values']); $result_values['contribution'] = $contribution;
} }
// MEMBERSHIP CREATION // MEMBERSHIP CREATION