ProPeace/de.systopia.twingle
6
0
Fork 0
Code Issues 2 Pull requests Projects 1 Releases Packages Wiki Activity Actions

use the id instead of the name to look up profiles

Browse source
This commit is contained in:
Marc Michalsky 2023-08-03 15:06:27 +02:00 • committed by Jens Schuppe
parent 1d9e973e46
commit d9e51c67f6
4 changed files with 157 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

54
CRM/Twingle/Form/Profile.php
View file

@ -32,6 +32,12 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
*/
protected $profile;
/**
* The ID of this profile.
* @var int|NULL
*/
protected $profile_id = NULL;
/**
* @var string
*
@ -142,10 +148,11 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
$this->_op = 'create';
}
// Verify that a profile with the given name exists.
$profile_name = CRM_Utils_Request::retrieve('name', 'String', $this);
if (!$this->profile = CRM_Twingle_Profile::getProfile($profile_name)) {
$profile_name = NULL;
// Verify that a profile with the given id exists.
if ($this->_op != 'copy') {
$this->profile_id = CRM_Utils_Request::retrieve('id', 'Int', $this);
$this->profile = CRM_Twingle_Profile::getProfile($this->profile_id);
}
// Set redirect destination.
@ -153,12 +160,12 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
switch ($this->_op) {
case 'delete':
if ($profile_name) {
CRM_Utils_System::setTitle(E::ts('Delete Twingle API profile <em>%1</em>', [1 => $profile_name]));
if ($this->profile_id) {
CRM_Utils_System::setTitle(E::ts('Delete Twingle API profile <em>%1</em>', [1 => $this->profile->getName()]));
$this->addButtons([
[
'type' => 'submit',
'name' => ($profile_name == 'default' ? E::ts('Reset') : E::ts('Delete')),
'name' => ($this->profile->getName() == 'default' ? E::ts('Reset') : E::ts('Delete')),
'isDefault' => TRUE,
],
]);
@ -166,40 +173,37 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
parent::buildQuickForm();
return;
case 'edit':
// When editing without a valid profile name, edit the default profile.
if (!$profile_name) {
$profile_name = 'default';
$this->profile = CRM_Twingle_Profile::getProfile($profile_name);
}
CRM_Utils_System::setTitle(E::ts('Edit Twingle API profile <em>%1</em>', [1 => $this->profile->getName()]));
break;
case 'copy':
// Retrieve the source profile name.
$profile_name = CRM_Utils_Request::retrieve('source_name', 'String', $this);
// When copying without a valid profile name, copy the default profile.
if (!$profile_name) {
$profile_name = 'default';
$source_id = CRM_Utils_Request::retrieve('source_id', 'Int', $this);
// When copying without a valid profile id, copy the default profile.
if (!$source_id) {
$this->profile = CRM_Twingle_Profile::createDefaultProfile();
} else {
$source_profile = CRM_Twingle_Profile::getProfile($source_id);
$this->profile = $source_profile->copy();
}
$this->profile = clone CRM_Twingle_Profile::getProfile($profile_name);
// Propose a new name for this profile.
$profile_name = $profile_name . '_copy';
$profile_name = $this->profile->getName() . '_copy';
$this->profile->setName($profile_name);
CRM_Utils_System::setTitle(E::ts('New Twingle API profile'));
break;
case 'edit':
CRM_Utils_System::setTitle(E::ts('Edit Twingle API profile <em>%1</em>', [1 => $this->profile->getName()]));
break;
case 'create':
// Load factory default profile values.
$this->profile = CRM_Twingle_Profile::createDefaultProfile($profile_name);
$this->profile = CRM_Twingle_Profile::createDefaultProfile(E::ts('New Profile'));
CRM_Utils_System::setTitle(E::ts('New Twingle API profile'));
break;
}
// Assign template variables.
$this->assign('op', $this->_op);
$this->assign('profile_name', $profile_name);
$this->assign('profile_name', $this->profile->getName());
$this->assign('is_default', $this->profile->is_default());
// Add form elements.
$is_default = $profile_name == 'default';