ProPeace/de.systopia.twingle
6
0
Fork 0
Code Issues 2 Pull requests Projects 1 Releases Packages Wiki Activity Actions

Code style

Browse source
This commit is contained in:
Jens Schuppe 2024-06-12 15:18:35 +02:00
parent cd008d9545
commit 0cf7ccb1cb
3 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CRM/Twingle/Form/Profile.php
View file

@ -607,7 +607,8 @@ class CRM_Twingle_Form_Profile extends CRM_Core_Form {
if (!isset($profile_data[$key]) && $required) { if (!isset($profile_data[$key]) && $required) {
CRM_Core_Session::setStatus( CRM_Core_Session::setStatus(
E::ts( E::ts(
'The required configuration option "%1" has no value. Saving the profile might set this option to a possibly unwanted default value.', 'The required configuration option "%1" has no value.'
. ' Saving the profile might set this option to a possibly unwanted default value.',
[1 => $metadata['label'] ?? $key] [1 => $metadata['label'] ?? $key]
), ),
E::ts('Error'), E::ts('Error'),

5
CRM/Twingle/Tools.php
View file

@ -116,7 +116,10 @@ class CRM_Twingle_Tools {
* Recurring contribution fields. * Recurring contribution fields.
* @throws Exception could be one of the measures * @throws Exception could be one of the measures
*/ */
public static function processRecurringContributionTermination(int $recurring_contribution_id, array $recurring_contribution) { public static function processRecurringContributionTermination(
int $recurring_contribution_id,
array $recurring_contribution
) {
// check if we're suspended // check if we're suspended
if (self::$protection_suspended) { if (self::$protection_suspended) {
return; return;

12
api/v3/TwingleDonation/Submit.php
View file

@ -532,8 +532,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
: 'false'; : 'false';
if ( if (
(bool) $profile->getAttribute('newsletter_double_opt_in') (bool) $profile->getAttribute('newsletter_double_opt_in')
&& isset($params['newsletter']) && (bool) ($params['newsletter'] ?? FALSE)
&& 1 == $params['newsletter']
&& is_array($groups = $profile->getAttribute('newsletter_groups')) && is_array($groups = $profile->getAttribute('newsletter_groups'))
) { ) {
$group_memberships = array_column( $group_memberships = array_column(
@ -573,8 +572,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
// If requested, add contact to newsletter groups defined in the profile. // If requested, add contact to newsletter groups defined in the profile.
} }
elseif ( elseif (
isset($params['newsletter']) (bool) ($params['newsletter'] ?? FALSE)
&& 1 == $params['newsletter']
&& is_array($groups = $profile->getAttribute('newsletter_groups')) && is_array($groups = $profile->getAttribute('newsletter_groups'))
) { ) {
foreach ($groups as $group_id) { foreach ($groups as $group_id) {
@ -593,8 +591,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
// If requested, add contact to postinfo groups defined in the profile. // If requested, add contact to postinfo groups defined in the profile.
if ( if (
isset($params['postinfo']) (bool) ($params['postinfo'] ?? FALSE)
&& 1 == $params['postinfo']
&& is_array($groups = $profile->getAttribute('postinfo_groups')) && is_array($groups = $profile->getAttribute('postinfo_groups'))
) { ) {
foreach ($groups as $group_id) { foreach ($groups as $group_id) {
@ -611,8 +608,7 @@ function civicrm_api3_twingle_donation_Submit($params) {
// profile. If an organisation is provided, add it to the groups instead. // profile. If an organisation is provided, add it to the groups instead.
// (see issue #83) // (see issue #83)
if ( if (
isset($params['donation_receipt']) (bool) ($params['donation_receipt'] ?? FALSE)
&& 1 == $params['donation_receipt']
&& is_array($groups = $profile->getAttribute('donation_receipt_groups')) && is_array($groups = $profile->getAttribute('donation_receipt_groups'))
) { ) {
foreach ($groups as $group_id) { foreach ($groups as $group_id) {